src/opts/SkXfermode_opts_none.cpp - Issue 26627004: ARM Skia NEON patches - 30 - Xfermode: NEON modeprocs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/opts/SkXfermode_opts_none.cpp

Issue 26627004: ARM Skia NEON patches - 30 - Xfermode: NEON modeprocs (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Fix optional NEON Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 #include "SkXfermode.h"	1 #include "SkXfermode.h"

2 #include "SkXfermode_proccoeff.h"	2 #include "SkXfermode_proccoeff.h"

	3 #include "SkUtilsArm.h"

3	4

	5 #if SK_ARM_NEON_IS_NONE
	djsollen 2013/10/10 12:47:46 I would create an _opts_arm.cpp that has this cha I would create an _opts_arm.cpp that has this change and leave *_none.cpp as is. I know it seems a bit redundant but it keeps the separation cleaner and in the event that we add optimizations for other platforms we don't end up with a bunch of ifdefs in this file.
4 // The prototype below is for Clang	6 // The prototype below is for Clang

5 extern SkProcCoeffXfermode* SkPlatformXfermodeFactory(const ProcCoeff& rec,	7 extern SkProcCoeffXfermode* SkPlatformXfermodeFactory(const ProcCoeff& rec,

6 SkXfermode::Mode mode);	8 SkXfermode::Mode mode);

7	9

8 SkProcCoeffXfermode* SkPlatformXfermodeFactory(const ProcCoeff& rec,	10 SkProcCoeffXfermode* SkPlatformXfermodeFactory(const ProcCoeff& rec,

9 SkXfermode::Mode mode) {	11 SkXfermode::Mode mode) {

10 return NULL;	12 return NULL;

11 }	13 }

	14 #endif

OLD	NEW

« gyp/opts.gyp ('K') | « src/opts/SkXfermode_opts_arm.cpp ('k') | no next file » | no next file with comments »