Issue 2662693002: Call addFile() before getErrors() to actually get errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2662693002: Call addFile() before getErrors() to actually get errors. (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Call addFile() before getErrors() to actually get errors. With this change we have only 7 failing shared tests. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/39a5e660cd2740f4f3e0289b8c011e61fee92627

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	pkg/analyzer_cli/lib/src/analyzer_impl.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 10 months ago (2017-01-27 23:11:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
39a5e660cd2740f4f3e0289b8c011e61fee92627 (presubmit successful).