third_party/WebKit/LayoutTests/fast/alignment/resources/alignment-parsing-utils-th.js - Issue 2662573002: [css-align] Implement place-content alignment shorthand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/alignment/resources/alignment-parsing-utils-th.js

Issue 2662573002: [css-align] Implement place-content alignment shorthand (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/alignment/parse-place-content.html ('K') | « third_party/WebKit/LayoutTests/fast/alignment/parse-place-content.html ('k') | third_party/WebKit/Source/core/css/CSSProperties.in » ('j') | third_party/WebKit/Source/core/css/CSSProperties.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/alignment/resources/alignment-parsing-utils-th.js

diff --git a/third_party/WebKit/LayoutTests/fast/alignment/resources/alignment-parsing-utils-th.js b/third_party/WebKit/LayoutTests/fast/alignment/resources/alignment-parsing-utils-th.js

index ee35414d8c3f0e2d5531e70a08cd03f76cc9e07b..f24439caad387d132d10beb456da3198cfb1a2e8 100644

--- a/third_party/WebKit/LayoutTests/fast/alignment/resources/alignment-parsing-utils-th.js

+++ b/third_party/WebKit/LayoutTests/fast/alignment/resources/alignment-parsing-utils-th.js

@@ -2,7 +2,9 @@ function checkValues(element, property, propertyID, value, computedValue)

{

window.element = element;

var elementID = element.id || "element";

- assert_equals(eval("element.style." + property), value, property + " specified value is not what it should..");

+ assert_equals(

+ eval('element.style.' + property), value,

+ property + ' specified value is not what it should.');

svillar 2017/02/02 09:11:19 unrelated change?

jfernandez 2017/02/06 15:17:17 Umm, I guess git cl format applied some changes he

assert_equals(eval("window.getComputedStyle(" + elementID + ", '').getPropertyValue('" + propertyID + "')"), computedValue, property + " is not what is should.");

}