Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 function checkValues(element, property, propertyID, value, computedValue) | 1 function checkValues(element, property, propertyID, value, computedValue) |
| 2 { | 2 { |
| 3 window.element = element; | 3 window.element = element; |
| 4 var elementID = element.id || "element"; | 4 var elementID = element.id || "element"; |
| 5 assert_equals(eval("element.style." + property), value, property + " specifi ed value is not what it should.."); | 5 assert_equals( |
| 6 eval('element.style.' + property), value, | |
| 7 property + ' specified value is not what it should.'); | |
|
svillar
2017/02/02 09:11:19
unrelated change?
jfernandez
2017/02/06 15:17:17
Umm, I guess git cl format applied some changes he
| |
| 6 assert_equals(eval("window.getComputedStyle(" + elementID + ", '').getProper tyValue('" + propertyID + "')"), computedValue, property + " is not what is shou ld."); | 8 assert_equals(eval("window.getComputedStyle(" + elementID + ", '').getProper tyValue('" + propertyID + "')"), computedValue, property + " is not what is shou ld."); |
| 7 } | 9 } |
| 8 | 10 |
| 9 function checkBadValues(element, property, propertyID, value) | 11 function checkBadValues(element, property, propertyID, value) |
| 10 { | 12 { |
| 11 var elementID = element.id || "element"; | 13 var elementID = element.id || "element"; |
| 12 var initialValue = eval("window.getComputedStyle(" + elementID + " , '').get PropertyValue('" + propertyID + "')"); | 14 var initialValue = eval("window.getComputedStyle(" + elementID + " , '').get PropertyValue('" + propertyID + "')"); |
| 13 element.style[property] = value; | 15 element.style[property] = value; |
| 14 checkValues(element, property, propertyID, "", initialValue); | 16 checkValues(element, property, propertyID, "", initialValue); |
| 15 } | 17 } |
| (...skipping 30 matching lines...) Expand all Loading... | |
| 46 parentElement.appendChild(element); | 48 parentElement.appendChild(element); |
| 47 checkValues(element, property, propertyID, "", value); | 49 checkValues(element, property, propertyID, "", value); |
| 48 } | 50 } |
| 49 | 51 |
| 50 function checkSupportedValues(elementID, property) | 52 function checkSupportedValues(elementID, property) |
| 51 { | 53 { |
| 52 var value = eval("window.getComputedStyle(" + elementID + " , '').getPropert yValue('" + property + "')"); | 54 var value = eval("window.getComputedStyle(" + elementID + " , '').getPropert yValue('" + property + "')"); |
| 53 var value1 = eval("window.getComputedStyle(" + elementID + " , '')"); | 55 var value1 = eval("window.getComputedStyle(" + elementID + " , '')"); |
| 54 shouldBeTrue("CSS.supports('" + property + "', '" + value + "')"); | 56 shouldBeTrue("CSS.supports('" + property + "', '" + value + "')"); |
| 55 } | 57 } |
| OLD | NEW |