Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: pkg/compiler/lib/src/ssa/optimize.dart

Issue 2662493004: Redo "dart2js: Redo known-type analysis after load-elimination" (Closed)
Patch Set: remove incorrect assert Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/optimize.dart
diff --git a/pkg/compiler/lib/src/ssa/optimize.dart b/pkg/compiler/lib/src/ssa/optimize.dart
index 680c38716e8ddb99dfed7a5807d1c9d2e3405cfb..c9d1863c35141eabe5aefe217908f7d6251746f2 100644
--- a/pkg/compiler/lib/src/ssa/optimize.dart
+++ b/pkg/compiler/lib/src/ssa/optimize.dart
@@ -88,6 +88,10 @@ class SsaOptimizerTask extends CompilerTask {
new SsaLoadElimination(compiler, closedWorld),
new SsaRedundantPhiEliminator(),
new SsaDeadPhiEliminator(),
+ // After GVN and load elimination the same value may be used in code
+ // controlled by a test on the value, so redo 'conversion insertion' to
+ // learn from the refined type.
+ new SsaTypeConversionInserter(closedWorld),
new SsaTypePropagator(compiler, closedWorld),
new SsaValueRangeAnalyzer(backend.helpers, closedWorld, this),
// Previous optimizations may have generated new
« pkg/compiler/lib/src/ssa/codegen.dart ('K') | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698