Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10752)

Unified Diff: chrome/installer/linux/debian/build.sh

Issue 2662493002: Unbundle dpkg-shlibdeps (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/linux/BUILD.gn ('k') | third_party/dpkg-dev/LICENSE » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/linux/debian/build.sh
diff --git a/chrome/installer/linux/debian/build.sh b/chrome/installer/linux/debian/build.sh
index d8c50a67468d3bf3e891c0738d912c37ae5d7903..a2314b514f3186a1bf2a55d7108c8215e0b28bd2 100755
--- a/chrome/installer/linux/debian/build.sh
+++ b/chrome/installer/linux/debian/build.sh
@@ -129,7 +129,6 @@ usage() {
echo "-b dir build input directory [${BUILDDIR}]"
echo "-d brand either chromium or google_chrome"
echo "-s dir /path/to/sysroot"
- echo "-e dir /path/to/dpkg-dev"
echo "-h this help message"
}
@@ -164,7 +163,7 @@ verify_channel() {
}
process_opts() {
- while getopts ":e:s:o:b:c:a:d:h" OPTNAME
+ while getopts ":s:o:b:c:a:d:h" OPTNAME
do
case $OPTNAME in
o )
@@ -186,9 +185,6 @@ process_opts() {
s )
SYSROOT="$OPTARG"
;;
- e )
- DPKG_DEV_DIR="$OPTARG"
- ;;
h )
usage
exit 0
@@ -282,11 +278,8 @@ else
SHLIB_ARGS="${SHLIB_ARGS} -l${SYSROOT}/lib/i386-linux-gnu"
fi
SHLIB_ARGS="${SHLIB_ARGS} -l${SYSROOT}/usr/lib"
-# TODO(thomasanderson): Unbundle dpkg-shlibdeps once the Precise->Trusty
-# transition is complete by reverting CL 2411423002 and applying ps40001.
-DPKG_SHLIB_DEPS=$(cd ${SYSROOT} && DPKG_DATADIR=${DPKG_DEV_DIR} \
- perl -I ${DPKG_DEV_DIR}/scripts ${DPKG_DEV_DIR}/scripts/dpkg-shlibdeps.pl \
- ${SHLIB_ARGS:-} -O -e"$BUILDDIR/chrome" | sed 's/^shlibs:Depends=//')
+DPKG_SHLIB_DEPS=$(cd ${SYSROOT} && dpkg-shlibdeps ${SHLIB_ARGS:-} -O \
+ -e"$BUILDDIR/chrome" | sed 's/^shlibs:Depends=//')
if [ -n "$SAVE_LDLP" ]; then
LD_LIBRARY_PATH=$SAVE_LDLP
fi
« no previous file with comments | « chrome/installer/linux/BUILD.gn ('k') | third_party/dpkg-dev/LICENSE » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698