Issue 2662483003: Better error message for missing async with await

Issue 2662483003: Better error message for missing async with await (Closed)

Created:
3 years, 10 months ago by jcollins

Modified:
3 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Better error message for missing async with await R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/93c3a194ade285969fd4ee9ae0bd95b373c5b4d9

Patch Set 2 : Add a period at the end of the sentence #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	pkg/analysis_server/test/services/correction/fix_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/analyzer/lib/src/error/codes.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

https://codereview.chromium.org/2662483003/diff/1/pkg/analyzer/lib/src/error/codes.dart File pkg/analyzer/lib/src/error/codes.dart (right): https://codereview.chromium.org/2662483003/diff/1/pkg/analyzer/lib/src/error/codes.dart#newcode4545 pkg/analyzer/lib/src/error/codes.dart:4545: "Undefined name 'await' in function body not marked with ...

3 years, 10 months ago (2017-01-27 18:41:56 UTC) #3

jcollins

3 years, 10 months ago (2017-01-27 18:48:38 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
93c3a194ade285969fd4ee9ae0bd95b373c5b4d9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages