Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: chrome/browser/extensions/favicon_downloader.h

Issue 2662443005: Convert FaviconDownloader to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/favicon_downloader.h
diff --git a/chrome/browser/extensions/favicon_downloader.h b/chrome/browser/extensions/favicon_downloader.h
index 77cf859695718f37614e35fa7cec2151d9bc8956..09b96d61e2efb81466cea577fa5446f33b59b718 100644
--- a/chrome/browser/extensions/favicon_downloader.h
+++ b/chrome/browser/extensions/favicon_downloader.h
@@ -71,9 +71,8 @@ class FaviconDownloader : public content::WebContentsObserver {
const std::vector<gfx::Size>& original_bitmap_sizes);
// content::WebContentsObserver overrides:
- void DidNavigateMainFrame(
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) override;
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override;
void DidUpdateFaviconURL(
const std::vector<content::FaviconURL>& candidates) override;
« no previous file with comments | « no previous file | chrome/browser/extensions/favicon_downloader.cc » ('j') | chrome/browser/extensions/favicon_downloader.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698