Chromium Code Reviews| Index: content/browser/bluetooth/bluetooth_metrics.cc |
| diff --git a/content/browser/bluetooth/bluetooth_metrics.cc b/content/browser/bluetooth/bluetooth_metrics.cc |
| index 8cbd38d0da81034d2283504bb0e50560d8f0238b..d9ae54fb1e2d656fc417fd78a4d1df114bbbc8e1 100644 |
| --- a/content/browser/bluetooth/bluetooth_metrics.cc |
| +++ b/content/browser/bluetooth/bluetooth_metrics.cc |
| @@ -284,7 +284,7 @@ void RecordGATTOperationOutcome(UMAGATTOperation operation, |
| RecordDescriptorReadValueOutcome(outcome); |
| return; |
| case UMAGATTOperation::DESCRIPTOR_WRITE: |
| - // TODO(683477) reporting for .writeValue() |
| + RecordDescriptorWriteValueOutcome(outcome); |
| return; |
| case UMAGATTOperation::COUNT: |
| NOTREACHED(); |
| @@ -371,6 +371,19 @@ void RecordDescriptorReadValueOutcome(CacheQueryOutcome outcome) { |
| TranslateCacheQueryOutcomeToGATTOperationOutcome(outcome)); |
| } |
| +// Descriptor.writeValue |
| + |
|
ortuno
2017/01/31 19:11:51
nit: remove unnecessary line.
|
| +void RecordDescriptorWriteValueOutcome(UMAGATTOperationOutcome outcome) { |
| + UMA_HISTOGRAM_ENUMERATION("Bluetooth.Web.Descriptor.WriteValue.Outcome", |
| + static_cast<int>(outcome), |
| + static_cast<int>(UMAGATTOperationOutcome::COUNT)); |
| +} |
| + |
| +void RecordDescriptorWriteValueOutcome(CacheQueryOutcome outcome) { |
| + RecordDescriptorWriteValueOutcome( |
| + TranslateCacheQueryOutcomeToGATTOperationOutcome(outcome)); |
| +} |
| + |
| void RecordRSSISignalStrengthLevel(UMARSSISignalStrengthLevel level) { |
| UMA_HISTOGRAM_ENUMERATION( |
| "Bluetooth.Web.RequestDevice.RSSISignalStrengthLevel", |