Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 266243003: Re^3-land "Ship promises and weak collections" (Closed)

Created:
6 years, 7 months ago by rossberg
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Re^3-land "Ship promises and weak collections" R=jochen@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -262 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 8 chunks +23 lines, -25 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +1 line, -8 lines 0 comments Download
M src/promise.js View 7 chunks +22 lines, -26 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-microtask-delivery.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/microtask-delivery.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/promises.js View 2 chunks +25 lines, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-2034.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/regress/regress-2156.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-2829.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/weak_collections.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es7/object-observe.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/harmony/collections.js View 2 chunks +8 lines, -7 lines 0 comments Download
D test/mjsunit/harmony/microtask-delivery.js View 1 chunk +0 lines, -168 lines 0 comments Download
M test/mjsunit/harmony/private.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-hash.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-observe-empty-double-array.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/symbols.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-350864.js View 1 chunk +1 line, -1 line 0 comments Download
M test/promises-aplus/promises-aplus.status View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/webkit.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 7 months ago (2014-05-06 14:35:13 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-06 14:37:24 UTC) #2
rossberg
6 years, 7 months ago (2014-05-06 14:48:55 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r21173 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698