Make displayAsyncThen use the CompositeAndReadbackAsync path.

content/shell/renderer/test_runner/WebTestProxy.cpp

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/test_runner/WebTestProxy.h"
 
 #include <cctype>
 
 #include "base/callback_helpers.h"
 #include "base/debug/trace_event.h"
@@ skipping 470 matching lines @@
 
 void WebTestProxyBase::didCompositeAndReadback(const SkBitmap& bitmap) {
   TRACE_EVENT2("shell",
                "WebTestProxyBase::didCompositeAndReadback",
                "x",
                bitmap.info().fWidth,
                "y",
                bitmap.info().fHeight);
   SkCanvas canvas(bitmap);
   DrawSelectionRect(&canvas);
-  DCHECK(!m_compositeAndReadbackCallback.is_null());
-  base::ResetAndReturn(&m_compositeAndReadbackCallback).Run(bitmap);
+  DCHECK(!m_compositeAndReadbackCallbacks.empty());
+  m_compositeAndReadbackCallbacks.front().Run(bitmap);
+  m_compositeAndReadbackCallbacks.pop_front();
 }
 
 void WebTestProxyBase::CapturePixelsAsync(
     base::Callback<void(const SkBitmap&)> callback) {
   TRACE_EVENT0("shell", "WebTestProxyBase::CapturePixelsAsync");
 
   DCHECK(webWidget()->isAcceleratedCompositingActive());
   DCHECK(!callback.is_null());
-  DCHECK(m_compositeAndReadbackCallback.is_null());
-  m_compositeAndReadbackCallback = callback;
+  m_compositeAndReadbackCallbacks.push_back(callback);
   webWidget()->compositeAndReadbackAsync(this);
 }
 
 void WebTestProxyBase::setLogConsoleOutput(bool enabled)
 {
     m_logConsoleOutput = enabled;
 }
 
 void WebTestProxyBase::paintRect(const WebRect& rect)
 {
@@ skipping 76 matching lines @@
     float deviceScaleFactor = webView()->deviceScaleFactor();
     int scaledWidth = static_cast<int>(ceil(static_cast<float>(widgetSize.width) * deviceScaleFactor));
     int scaledHeight = static_cast<int>(ceil(static_cast<float>(widgetSize.height) * deviceScaleFactor));
     // We're allocating the canvas to be non-opaque (third parameter), so we
     // don't end up with uninitialized memory if a layout test doesn't damage
     // the entire view.
     m_canvas.reset(skia::CreateBitmapCanvas(scaledWidth, scaledHeight, false));
     return m_canvas.get();
 }
 
-void WebTestProxyBase::display(base::Closure callback)
-{
-    const blink::WebSize& size = webWidget()->size();
-    WebRect rect(0, 0, size.width, size.height);
-    m_paintRect = rect;
-    paintInvalidatedRegion();
+void WebTestProxyBase::DisplayForSoftwareMode(const base::Closure& callback) {
+  const blink::WebSize& size = webWidget()->size();
+  WebRect rect(0, 0, size.width, size.height);
+  m_paintRect = rect;
+  paintInvalidatedRegion();
 
-    if (!callback.is_null())
-        callback.Run();
+  if (!callback.is_null())
+    callback.Run();
 }
 
-void WebTestProxyBase::displayAsyncThen(base::Closure callback)
-{
-  // TODO(enne): When compositing, this should invoke a real rAF, paint,
-  // and commit.  For now, just make sure that displayAsync is actually
-  // async so that callers can't depend on synchronous behavior.
-  m_delegate->postTask(new ClosureTask(
-      this,
-      base::Bind(
-          &WebTestProxyBase::display, base::Unretained(this), callback)));
+void WebTestProxyBase::DidDisplayAsync(const base::Closure& callback,
+                                       const SkBitmap& bitmap) {
+  // Verify we actually composited.
+  CHECK_NE(0, bitmap.info().fWidth);
+  CHECK_NE(0, bitmap.info().fHeight);
+  if (!callback.is_null())
+    callback.Run();
+}
+
+void WebTestProxyBase::displayAsyncThen(base::Closure callback) {
+  TRACE_EVENT0("shell", "WebTestProxyBase::displayAsyncThen");
+
+  // TODO(danakj): Remove when we have kForceCompositingMode everywhere.
+  if (!webWidget()->isAcceleratedCompositingActive()) {
+    TRACE_EVENT0("shell",
+                 "WebTestProxyBase::displayAsyncThen "
+                 "isAcceleratedCompositingActive false");
+    m_delegate->postTask(
+        new ClosureTask(this,
+                        base::Bind(&WebTestProxyBase::DisplayForSoftwareMode,
+                                   base::Unretained(this),
+                                   callback)));
+    return;
+  }
+
+  CapturePixelsAsync(base::Bind(
+      &WebTestProxyBase::DidDisplayAsync, base::Unretained(this), callback));
 }
 
 void WebTestProxyBase::discardBackingStore()
 {
     m_canvas.reset();
 }
 
 WebMIDIClientMock* WebTestProxyBase::midiClientMock()
 {
     if (!m_midiClient.get())
@@ skipping 666 matching lines @@
 
 void WebTestProxyBase::resetInputMethod()
 {
     // If a composition text exists, then we need to let the browser process
     // to cancel the input method's ongoing composition session.
     if (m_webWidget)
         m_webWidget->confirmComposition();
 }
 
 }  // namespace content