The file is a library, if it has a 'library' directive.

The file is a library, if it has a 'library' directive.

With these changes analyzer_cli with the new analysis driver can pass
the same shared tests as the AnalysisContext based analyzer_cli.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/8835fe34fdd31570990e3ec93c4bac274edc7cfb

[Brian Wilkerson, 2017-01-31 20:33:00]

https://codereview.chromium.org/2662363002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right):

https://codereview.chromium.org/2662363002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:197: bool get isPart =>
_unlinked.libraryNameOffset == 0 &&  _unlinked.isPartOf;
I'm concerned about this because it appears that unlinked summaries have a
different definition of when they are a part than other places in the code base.
I think summaries should be consistent. Could we change `isPartOf` to return
false if there is a library directive?

[Brian Wilkerson, 2017-01-31 20:35:06]

After discussion, lgtm.

[scheglov, 2017-01-31 21:07:01]

Description was changed from

==========
The file is a library, if it has a 'library' directive.

With these changes analyzer_cli with the new analysis driver can pass
the same shared tests as the AnalysisContext based analyzer_cli.

R=brianwilkerson@google.com
BUG=
==========

to

==========
The file is a library, if it has a 'library' directive.

With these changes analyzer_cli with the new analysis driver can pass
the same shared tests as the AnalysisContext based analyzer_cli.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/8835fe34fdd31570990e3ec93c4bac274edc7cfb
==========

[scheglov, 2017-01-31 21:07:02]

Committed patchset #1 (id:1) manually as
8835fe34fdd31570990e3ec93c4bac274edc7cfb (presubmit successful).