Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2662333002: Start adding vm/cc tests for rewind functionality. (Closed)

Created:
3 years, 10 months ago by turnidge
Modified:
3 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Start adding vm/cc tests for rewind functionality. These will make it easier to debug rewind on simdbc64. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/bbc2ac93a305f4ea223a894f0f6ab4083ee06ce9

Patch Set 1 #

Total comments: 6

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -7 lines) Patch
M runtime/tests/vm/vm.status View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_message.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger_test.cc View 1 3 chunks +204 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
M runtime/vm/service.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
turnidge
3 years, 10 months ago (2017-01-31 19:10:05 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2662333002/diff/1/runtime/vm/dart_api_message.cc File runtime/vm/dart_api_message.cc (right): https://codereview.chromium.org/2662333002/diff/1/runtime/vm/dart_api_message.cc#newcode1295 runtime/vm/dart_api_message.cc:1295: fprintf(stderr, "Unexpected Dart_CObject_Type %d\n", type); FATAL1("Unexpected Dart_CObject_Type %d\n", ...
3 years, 10 months ago (2017-01-31 19:21:00 UTC) #3
turnidge
https://codereview.chromium.org/2662333002/diff/1/runtime/vm/dart_api_message.cc File runtime/vm/dart_api_message.cc (right): https://codereview.chromium.org/2662333002/diff/1/runtime/vm/dart_api_message.cc#newcode1295 runtime/vm/dart_api_message.cc:1295: fprintf(stderr, "Unexpected Dart_CObject_Type %d\n", type); On 2017/01/31 19:21:00, rmacnak ...
3 years, 10 months ago (2017-01-31 19:35:46 UTC) #4
turnidge
3 years, 10 months ago (2017-01-31 20:02:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
bbc2ac93a305f4ea223a894f0f6ab4083ee06ce9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698