Issue 26623002: Use toCSSFooValue() instead of using static_cast<const CSSFooValue*>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26623002: Use toCSSFooValue() instead of using static_cast<const CSSFooValue*> (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive

Modified:
7 years, 2 months ago

Reviewers:
tkent

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use toCSSFooValue() instead of using static_cast<const CSSFooValue*> Cleanup static_cast<const CSSFooValue*> in order to detect bad type casts. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159212

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -49 lines)			Patch
	M	Source/core/css/CSSImageGeneratorValue.cpp	View		3 chunks	+11 lines, -11 lines	0 comments	Download
	M	Source/core/css/CSSValue.cpp	View		7 chunks	+38 lines, -38 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/26623002/1

7 years, 2 months ago (2013-10-09 00:06:14 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=9634

7 years, 2 months ago (2013-10-09 06:17:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/26623002/1

7 years, 2 months ago (2013-10-09 06:21:25 UTC) #5

Message was sent while issue was closed.

Change committed as 159212

Expand Messages | Collapse Messages