Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2662253002: Handle private dynamic access in impact_test. (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M pkg/compiler/lib/src/serialization/equivalence.dart View 2 chunks +17 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-01-31 14:06:37 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-01-31 21:44:25 UTC) #3
Johnni Winther
3 years, 10 months ago (2017-02-01 09:15:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7060fa7209032cd40e046a9d440821989c1f6934 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698