Do not try to read vm-service and kernel-service

Do not try to read vm-service and kernel-service

The VM service isolate and the Kernel service isolate are given script
URIs that are respectively "vm-service" and "kernel-service".  We
should not try to treat these as binary files.  Normally they just
don't exist, but if they happen to exist we should not read them.

BUG=
R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/1b3b85690f9d85ccd926e5d73609a995bb011c11

[Kevin Millikin (Google), 2017-01-31 15:35:35]

kmillikin@google.com changed reviewers:
+ kustermann@google.com

[Kevin Millikin (Google), 2017-02-01 09:08:47]

Description was changed from

==========
Do not try to read vm-service and kernel-service

The VM service isolate and the Kernel service isolate are given script
URIs that are respectively "vm-service" and "kernel-service".  We
should not try to treat these as binary files.  Normally they just
don't exist, but if they happen to exist we should not read them.

BUG=
==========

to

==========
Do not try to read vm-service and kernel-service

The VM service isolate and the Kernel service isolate are given script
URIs that are respectively "vm-service" and "kernel-service".  We
should not try to treat these as binary files.  Normally they just
don't exist, but if they happen to exist we should not read them.

BUG=
==========

[Kevin Millikin (Google), 2017-02-01 11:44:40]

kmillikin@google.com changed reviewers:
+ vegorov@google.com

[Kevin Millikin (Google), 2017-02-01 11:44:41]

+vegorov

[Kevin Millikin (Google), 2017-02-01 11:45:45]

https://codereview.chromium.org/2662213004/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (left):

https://codereview.chromium.org/2662213004/diff/1/runtime/bin/main.cc#oldcode889
runtime/bin/main.cc:889: is_kernel = TryReadKernel(script_uri, &kernel_file,
&kernel_length);
This was not guarded by !is_kernel_isolate && !is_service_isolate.

[Vyacheslav Egorov (Google), 2017-02-01 11:54:47]

lgtm

[Kevin Millikin (Google), 2017-02-01 11:59:09]

Description was changed from

==========
Do not try to read vm-service and kernel-service

The VM service isolate and the Kernel service isolate are given script
URIs that are respectively "vm-service" and "kernel-service".  We
should not try to treat these as binary files.  Normally they just
don't exist, but if they happen to exist we should not read them.

BUG=
==========

to

==========
Do not try to read vm-service and kernel-service

The VM service isolate and the Kernel service isolate are given script
URIs that are respectively "vm-service" and "kernel-service".  We
should not try to treat these as binary files.  Normally they just
don't exist, but if they happen to exist we should not read them.

BUG=
R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1b3b85690f9d85ccd926e5d73609a995bb011c11
==========

[Kevin Millikin (Google), 2017-02-01 11:59:10]

Committed patchset #1 (id:1) manually as
1b3b85690f9d85ccd926e5d73609a995bb011c11 (presubmit successful).