Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2662213003: Revert of Disable browse:media:imgur in telemetry_perf_unittests (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run all system health stories used by system health benchmarks. 5 """Run all system health stories used by system health benchmarks.
6 6
7 Only memory benchmarks are used when running these stories to make the total 7 Only memory benchmarks are used when running these stories to make the total
8 cycle time manageable. Other system health benchmarks should be using the same 8 cycle time manageable. Other system health benchmarks should be using the same
9 stories as memory ones, only with fewer actions (no memory dumping). 9 stories as memory ones, only with fewer actions (no memory dumping).
10 """ 10 """
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.long_running:tools:gmail-background', # pylint: disable=line- too-long 44 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.long_running:tools:gmail-background', # pylint: disable=line- too-long
45 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.long_running:tools:gmail-foreground', # pylint: disable=line -too-long 45 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.long_running:tools:gmail-foreground', # pylint: disable=line -too-long
46 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.long_running:tools:gmail-background', # pylint: disable=line -too-long 46 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.long_running:tools:gmail-background', # pylint: disable=line -too-long
47 47
48 # Disable media tests in CQ. crbug.com/649392 48 # Disable media tests in CQ. crbug.com/649392
49 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.play:media:soundcloud', # pylint: disable=line-too-long 49 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.play:media:soundcloud', # pylint: disable=line-too-long
50 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.play:media:google_play_music', # pylint: disable=line-too-lo ng 50 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.play:media:google_play_music', # pylint: disable=line-too-lo ng
51 51
52 # crbug.com/ 52 # crbug.com/
53 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:nytimes', # pylint: disable=line-too-long 53 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:nytimes', # pylint: disable=line-too-long
54
55 # crbug.com/685967
56 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:media:imgur', # pylint: disable=line-too-long
57 }) 54 })
58 55
59 56
60 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): 57 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
61 58
62 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. 59 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
63 # 60 #
64 # This smoke test dynamically tests all system health user stories. So 61 # This smoke test dynamically tests all system health user stories. So
65 # disabling it for one failing or flaky benchmark would disable a much 62 # disabling it for one failing or flaky benchmark would disable a much
66 # wider swath of coverage than is usally intended. Instead, if a test is 63 # wider swath of coverage than is usally intended. Instead, if a test is
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 # parsed during test time which happens after load_tests are called. 142 # parsed during test time which happens after load_tests are called.
146 # Since none of our system health benchmarks creates stories based on 143 # Since none of our system health benchmarks creates stories based on
147 # command line options, it should be ok to pass options=None to 144 # command line options, it should be ok to pass options=None to
148 # CreateStorySet. 145 # CreateStorySet.
149 for story_to_smoke_test in ( 146 for story_to_smoke_test in (
150 benchmark_class().CreateStorySet(options=None).stories): 147 benchmark_class().CreateStorySet(options=None).stories):
151 suite.addTest( 148 suite.addTest(
152 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) 149 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
153 150
154 return suite 151 return suite
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698