Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26622007: Move isAutofilled and setAutofilled from HTMLInputElement to HTMLFormControlElement (Closed)

Created:
7 years, 2 months ago by Ilya Sherman
Modified:
7 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, jamesr, abarth-chromium, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears
Visibility:
Public.

Description

Move isAutofilled and setAutofilled from HTMLInputElement to HTMLFormControlElement This is in support of enabling Autofill for <textarea> elements. BUG=280499 TEST=fast/forms/*autofill* R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159316

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update messaging in test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -77 lines) Patch
M LayoutTests/fast/forms/input-autofilled.html View 1 3 chunks +57 lines, -23 lines 0 comments Download
M LayoutTests/fast/forms/input-autofilled-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/reset-autofilled.html View 1 3 chunks +9 lines, -5 lines 0 comments Download
M LayoutTests/fast/forms/reset-autofilled-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/html.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 4 chunks +7 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 3 chunks +16 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 3 chunks +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 3 chunks +1 line, -12 lines 0 comments Download
M Source/core/html/HTMLKeygenElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLKeygenElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOutputElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOutputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebFormControlElement.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/web/WebInputElement.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M public/web/WebFormControlElement.h View 1 chunk +3 lines, -0 lines 0 comments Download
M public/web/WebInputElement.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ilya Sherman
7 years, 2 months ago (2013-10-10 06:04:39 UTC) #1
tkent
lgtm https://codereview.chromium.org/26622007/diff/1/LayoutTests/fast/forms/input-autofilled.html File LayoutTests/fast/forms/input-autofilled.html (right): https://codereview.chromium.org/26622007/diff/1/LayoutTests/fast/forms/input-autofilled.html#newcode10 LayoutTests/fast/forms/input-autofilled.html:10: testFailed('This test requires a LayoutTestController.'); window.internals is not ...
7 years, 2 months ago (2013-10-10 07:19:38 UTC) #2
Ilya Sherman
https://codereview.chromium.org/26622007/diff/1/LayoutTests/fast/forms/input-autofilled.html File LayoutTests/fast/forms/input-autofilled.html (right): https://codereview.chromium.org/26622007/diff/1/LayoutTests/fast/forms/input-autofilled.html#newcode10 LayoutTests/fast/forms/input-autofilled.html:10: testFailed('This test requires a LayoutTestController.'); On 2013/10/10 07:19:38, tkent ...
7 years, 2 months ago (2013-10-10 07:47:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/26622007/6001
7 years, 2 months ago (2013-10-10 07:48:00 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-10 08:57:55 UTC) #5
Message was sent while issue was closed. 
Change committed as 159316

Powered by Google App Engine
This is Rietveld 408576698