Add UMA histogram for popup actions on Android.

chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.h"
 
 #include <stddef.h>
 #include <utility>
-
+#include "chrome/browser/content_settings/chrome_content_settings_utils.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/theme_resources.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/content_settings/core/common/content_settings.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 #include "components/infobars/core/infobar.h"
@@ skipping 22 matching lines @@
   // This will be fixed once we have an in place replace infobar mechanism.
   for (size_t i = 0; i < infobar_service->infobar_count(); ++i) {
     infobars::InfoBar* existing_infobar = infobar_service->infobar_at(i);
     if (existing_infobar->delegate()->AsPopupBlockedInfoBarDelegate()) {
       infobar_service->ReplaceInfoBar(existing_infobar, std::move(infobar));
       return;
     }
   }
 
   infobar_service->AddInfoBar(std::move(infobar));
+
+  content_settings::RecordPopupsAction(
+      content_settings::POPUPS_ACTION_DISPLAYED_INFOBAR_ON_MOBILE);

[Nico, 2017/02/02 22:09:49]

This looks like general code, why is the enum called _ON_MOBILE?

[charleszhao, 2017/02/03 02:20:48]

These two enum 
POPUPS_ACTION_DISPLAYED_INFOBAR_ON_MOBILE,
POPUPS_ACTION_CLICKED_ALWAYS_SHOW_ON_MOBILE
are only meaningful on Android and IOS,

And on desktop, the corespondent one is:
POPUPS_ACTION_DISPLAYED_BLOCKED_ICON_IN_OMNIBOX,
POPUPS_ACTION_SELECTED_ALWAYS_ALLOW_POPUPS_FROM,

That's the reason.

 }
 
 PopupBlockedInfoBarDelegate::~PopupBlockedInfoBarDelegate() {
 }
 
 infobars::InfoBarDelegate::InfoBarIdentifier
 PopupBlockedInfoBarDelegate::GetIdentifier() const {
   return POPUP_BLOCKED_INFOBAR_DELEGATE;
 }
 
@@ skipping 47 matching lines @@
       InfoBarService::WebContentsFromInfoBar(infobar());
   PopupBlockerTabHelper* popup_blocker_helper =
       PopupBlockerTabHelper::FromWebContents(web_contents);
   DCHECK(popup_blocker_helper);
   PopupBlockerTabHelper::PopupIdMap blocked_popups =
       popup_blocker_helper->GetBlockedPopupRequests();
   for (PopupBlockerTabHelper::PopupIdMap::iterator it = blocked_popups.begin();
       it != blocked_popups.end(); ++it)
     popup_blocker_helper->ShowBlockedPopup(it->first);
 
+  content_settings::RecordPopupsAction(
+      content_settings::POPUPS_ACTION_CLICKED_ALWAYS_SHOW_ON_MOBILE);

[Nico, 2017/02/02 22:09:49]

same question

[charleszhao, 2017/02/05 23:03:13]

Done.

   return true;
 }