chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc - Issue 2662103002: Refactor ManifestIconSelector and update it for Manifest.icon.purpose

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2662103002: Refactor ManifestIconSelector and update it for Manifest.icon.purpose (Closed)

Patch Set: Addressing comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

index a29a5c4b5f6fe48f4d13d7d630cc552d8893bb9c..cc11a59bf46ac648cdff950cea631d3c6649dc15 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

@@ -214,7 +214,8 @@ void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(

// Save the splash screen URL for the later download.

splash_screen_url_ = ManifestIconSelector::FindBestMatchingIcon(

data.manifest.icons, ideal_splash_image_size_in_px_,

- minimum_splash_image_size_in_px_);

+ minimum_splash_image_size_in_px_,

+ content::Manifest::Icon::IconPurpose::ANY);

weak_observer_->OnUserTitleAvailable(shortcut_info_.user_title);