Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2662033002: Remove analyzer workaround for #27447. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove analyzer workaround for #27447. This issue was fixed in the SDK sufficiently long ago that it doesn't seem necessary to keep the workaround in analyzer. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b3237d0ad8874af7ef75683be310b91bdc3f09c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/utilities_dart_test.dart View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 10 months ago (2017-01-30 20:39:23 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-01-30 20:40:18 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as b3237d0ad8874af7ef75683be310b91bdc3f09c1 (presubmit successful).
3 years, 10 months ago (2017-01-30 21:04:34 UTC) #5
Brian Wilkerson
3 years, 10 months ago (2017-01-30 21:17:08 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698