Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 266193009: Revert of Use experimental app list position whenever virtual keyboard is enabled. (Closed)

Created:
6 years, 7 months ago by Mike West
Modified:
6 years, 7 months ago
Reviewers:
varkha, benwells, Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, kalyank, sadrul, ben+ash_chromium.org, tfarina, kevers
Visibility:
Public.

Description

Revert of Use experimental app list position whenever virtual keyboard is enabled. (https://codereview.chromium.org/253983002/) Reason for revert: Broke compilation on for CrOS[1] and Win64[2]. [1]: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Full&number=3373 [2]: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder&number=18192 Original issue's description: > Use experimental app list position whenever virtual keyboard is enabled. > > The old app list position doesn't fit on the screen when the keyboard is > open. Therefore, whenever the virtual keyboard is enabled, use the new > app list position (centered and wide). > > BUG=369382 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268443 TBR=varkha@chromium.org,benwells@chromium.org,mgiuca@chromium.org NOTREECHECKS=true NOTRY=true BUG=369382 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -106 lines) Patch
M ash/wm/app_list_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux_unittest.cc View 4 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win_unittest.cc View 3 chunks +1 line, -18 lines 0 comments Download
M ui/app_list/app_list_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/app_list_view_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/app_list/test/app_list_test_view_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/test/app_list_test_view_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/views/app_list_main_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/app_list/views/app_list_main_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/views/app_list_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/views/apps_container_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike West
Created Revert of Use experimental app list position whenever virtual keyboard is enabled.
6 years, 7 months ago (2014-05-06 06:57:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/266193009/1
6 years, 7 months ago (2014-05-06 06:57:59 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 06:59:16 UTC) #3
Message was sent while issue was closed.
Change committed as 268446

Powered by Google App Engine
This is Rietveld 408576698