Log exceptions caught in polymer expressions

pkg/polymer_expressions/lib/polymer_expressions.dart

Index: pkg/polymer_expressions/lib/polymer_expressions.dart
diff --git a/pkg/polymer_expressions/lib/polymer_expressions.dart b/pkg/polymer_expressions/lib/polymer_expressions.dart
index e7148ad98be8ebce9e7b83f23d109da3929588a1..5eecab2b26378f98ccf40e2cbb5369132c43c7a2 100644
--- a/pkg/polymer_expressions/lib/polymer_expressions.dart
+++ b/pkg/polymer_expressions/lib/polymer_expressions.dart
@@ -100,6 +100,8 @@ class _Binding extends Object with ChangeNotifierMixin {
       _setValue(_expr.currentValue);
     } on EvalException catch (e) {
       _logger.warning("Error evaluating expression '$_expr': ${e.message}");
+    } catch (e) {

[Siggi Cherem (dart-lang), 2013/10/08 23:41:08]

should I merge this and the catch above together? I saw in many places we only
check for EvalException, but I wonder if we want to consistently catch
everything or only catch EvalExceptions?

[Jennifer Messerly, 2013/10/15 22:47:15]

IMO: only EvalException in both places.

[justinfagnani, 2013/10/16 00:37:08]

same, other exceptions are real application exceptions and not just nulls in the
binding path.

+      _logger.warning("Error evaluating expression '$_expr': ${e}");
     }
   }
 
@@ -125,8 +127,8 @@ class _Binding extends Object with ChangeNotifierMixin {
     try {
       assign(_expr, v, _scope);
       notifyChange(new PropertyChangeRecord(_VALUE));
-    } on EvalException catch (e) {
-      // silently swallow binding errors
+    } catch (e) {
+      _logger.warning("Error evaluating expression '$_expr': $e");
     }
   }