Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2661883002: Revert IA32 part of stub optimization (Closed)

Created:
3 years, 10 months ago by erikcorry
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert IA32 part of stub optimization Buildbot is not happy. R=vegorov@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d2860aff58ddaebcc8dfc6d34ba2c68f89dd7e87

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -101 lines) Patch
M runtime/vm/assembler_ia32.cc View 1 chunk +13 lines, -41 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 5 chunks +59 lines, -60 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
erikcorry
3 years, 10 months ago (2017-01-30 14:40:00 UTC) #1
Vyacheslav Egorov (Google)
rubberstamp lgtm
3 years, 10 months ago (2017-01-30 14:41:36 UTC) #2
erikcorry
Committed patchset #1 (id:1) manually as d2860aff58ddaebcc8dfc6d34ba2c68f89dd7e87 (presubmit successful).
3 years, 10 months ago (2017-01-30 14:42:14 UTC) #4
Vyacheslav Egorov (Google)
FYI https://codereview.chromium.org/2661883002/diff/1/runtime/vm/stub_code_ia32.cc File runtime/vm/stub_code_ia32.cc (left): https://codereview.chromium.org/2661883002/diff/1/runtime/vm/stub_code_ia32.cc#oldcode1379 runtime/vm/stub_code_ia32.cc:1379: __ movl(EDI, Address(EBX, 0)); The crash was here: ...
3 years, 10 months ago (2017-01-30 18:56:29 UTC) #5
erikcorry
3 years, 10 months ago (2017-01-30 20:46:41 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2661883002/diff/1/runtime/vm/stub_code_ia32.cc
File runtime/vm/stub_code_ia32.cc (left):

https://codereview.chromium.org/2661883002/diff/1/runtime/vm/stub_code_ia32.c...
runtime/vm/stub_code_ia32.cc:1379: __ movl(EDI, Address(EBX, 0));
On 2017/01/30 18:56:29, Vyacheslav Egorov (Google) wrote:
> The crash was here: this can be on the next page if array is allocated
touching
> the page boundary.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698