Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2661873002: Introduce ConstructorEntity (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -38 lines) Patch
M pkg/compiler/lib/src/core_types.dart View 6 chunks +12 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/entities.dart View 1 1 chunk +12 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_adapter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 6 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
https://codereview.chromium.org/2661873002/diff/1/pkg/compiler/lib/src/core_types.dart File pkg/compiler/lib/src/core_types.dart (left): https://codereview.chromium.org/2661873002/diff/1/pkg/compiler/lib/src/core_types.dart#oldcode355 pkg/compiler/lib/src/core_types.dart:355: FunctionEntity get mirrorsUsedConstructor { Never used.
3 years, 10 months ago (2017-01-30 10:01:09 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2661873002/diff/1/pkg/compiler/lib/src/elements/entities.dart File pkg/compiler/lib/src/elements/entities.dart (right): https://codereview.chromium.org/2661873002/diff/1/pkg/compiler/lib/src/elements/entities.dart#newcode63 pkg/compiler/lib/src/elements/entities.dart:63: /// constructors and methods and/or Dart-in-JS function-like properties. ...
3 years, 10 months ago (2017-01-30 18:51:37 UTC) #3
Johnni Winther
https://codereview.chromium.org/2661873002/diff/1/pkg/compiler/lib/src/elements/entities.dart File pkg/compiler/lib/src/elements/entities.dart (right): https://codereview.chromium.org/2661873002/diff/1/pkg/compiler/lib/src/elements/entities.dart#newcode63 pkg/compiler/lib/src/elements/entities.dart:63: /// constructors and methods and/or Dart-in-JS function-like properties. On ...
3 years, 10 months ago (2017-01-31 08:50:57 UTC) #4
Johnni Winther
3 years, 10 months ago (2017-01-31 08:56:36 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d743d2f2bcd0256fa75405b30711b224aa8c4dd7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698