Issue 28491. Add support for UnlinkedExprOperation.pushSuper even though it is not allowed.

Issue 28491. Add support for UnlinkedExprOperation.pushSuper even though it is not allowed.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/28491

Committed: https://github.com/dart-lang/sdk/commit/70dd81dd372b15a29a2fa9f54691c45e83530288

[Paul Berry, 2017-01-29 14:28:03]

lgtm assuming comment below is addressed.

https://codereview.chromium.org/2661803002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_common.dart (right):

https://codereview.chromium.org/2661803002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_common.dart:701: if (modifier ==
Modifier.REFERENCES_SUPER) {
We can't safely do this.  The modifier REFERENCES_SUPER *is* used for analysis
(it's used to detect if a class gets used illegaly as a mixin when "supermixin"
support isn't enabled).  So we need to check that it's resynthesized correctly.

In fact, looking through the code, it looks like you've uncovered a preexisting
bug in summaries: support for this modifier was never added to the summary
logic.  This means that if a user has "supermixin" support disabled, and they
try to mix in a class that references super, and that class comes from a
summary, an error won't be properly reported.

I've filed a bug to track this: https://github.com/dart-lang/sdk/issues/28553

Rather than skip the REFERENCES_SUPER check here, would you mind marking the
corresponding resynthesis test as failing, and referencing the bug in a comment?

[Brian Wilkerson, 2017-01-29 17:19:58]

Other than Paul's concern, lgtm.

[scheglov, 2017-01-29 18:05:15]

https://codereview.chromium.org/2661803002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_common.dart (right):

https://codereview.chromium.org/2661803002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_common.dart:701: if (modifier ==
Modifier.REFERENCES_SUPER) {
On 2017/01/29 14:28:02, Paul Berry wrote:
> We can't safely do this.  The modifier REFERENCES_SUPER *is* used for analysis
> (it's used to detect if a class gets used illegaly as a mixin when
"supermixin"
> support isn't enabled).  So we need to check that it's resynthesized
correctly.
> 
> In fact, looking through the code, it looks like you've uncovered a
preexisting
> bug in summaries: support for this modifier was never added to the summary
> logic.  This means that if a user has "supermixin" support disabled, and they
> try to mix in a class that references super, and that class comes from a
> summary, an error won't be properly reported.
> 
> I've filed a bug to track this: https://github.com/dart-lang/sdk/issues/28553
> 
> Rather than skip the REFERENCES_SUPER check here, would you mind marking the
> corresponding resynthesis test as failing, and referencing the bug in a
comment?

Done.

[scheglov, 2017-01-29 18:05:31]

Description was changed from

==========
Issue 28491. Add support for UnlinkedExprOperation.pushSuper even though it is
not allowed.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/28491
==========

to

==========
Issue 28491. Add support for UnlinkedExprOperation.pushSuper even though it is
not allowed.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/28491

Committed:
https://github.com/dart-lang/sdk/commit/70dd81dd372b15a29a2fa9f54691c45e83530288
==========

[scheglov, 2017-01-29 18:05:33]

Committed patchset #1 (id:1) manually as
70dd81dd372b15a29a2fa9f54691c45e83530288 (presubmit successful).