Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)
Patch Set: Fix build error Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index d123a03ceffb17247de312433aaba890b5e7b4b9..314616ee03fa6795399a10b07dbba76785d9127f 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -7351,7 +7351,8 @@ class TestHistoryWebFrameClient : public FrameTestHelpers::TestWebFrameClient {
m_frame = nullptr;
}
- void didStartProvisionalLoad(WebLocalFrame* frame) {
+ void didStartProvisionalLoad(WebLocalFrame* frame,
+ const WebURLRequest& request) {
WebDataSource* ds = frame->provisionalDataSource();
m_replacesCurrentHistoryItem = ds->replacesCurrentHistoryItem();
m_frame = frame;
@@ -10083,7 +10084,7 @@ class CallbackOrderingWebFrameClient
EXPECT_EQ(0, m_callbackCount++);
FrameTestHelpers::TestWebFrameClient::didStartLoading(toDifferentDocument);
}
- void didStartProvisionalLoad(WebLocalFrame*) override {
+ void didStartProvisionalLoad(WebLocalFrame*, const WebURLRequest&) override {
EXPECT_EQ(1, m_callbackCount++);
}
void didCommitProvisionalLoad(WebLocalFrame*,

Powered by Google App Engine
This is Rietveld 408576698