Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1938)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)
Patch Set: Fix build error Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 3457a0fe969b0ebd384f2bd29725fd824ca3cdc7..83970ec108ca4250b9734d01d321ee3aa9eeda9e 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3448,7 +3448,9 @@ void RenderFrameImpl::didCreateDataSource(blink::WebLocalFrame* frame,
content_initiated));
}
-void RenderFrameImpl::didStartProvisionalLoad(blink::WebLocalFrame* frame) {
+void RenderFrameImpl::didStartProvisionalLoad(
+ blink::WebLocalFrame* frame,
+ const blink::WebURLRequest& request) {
DCHECK_EQ(frame_, frame);
WebDataSource* ds = frame->provisionalDataSource();
@@ -6190,6 +6192,8 @@ void RenderFrameImpl::BeginNavigation(const NavigationPolicyInfo& info) {
CHECK(IsBrowserSideNavigationEnabled());
browser_side_navigation_pending_ = true;
+ didStartProvisionalLoad(frame_, info.urlRequest);
Nate Chapin 2017/01/31 22:13:32 Instead of adding a new path for calling didStartP
ananta 2017/02/02 01:29:23 Done.
+
// Note: At this stage, the goal is to apply all the modifications the
// renderer wants to make to the request, and then send it to the browser, so
// that the actual network request can be started. Ideally, all such
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698