content/public/renderer/render_frame_observer.h - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/render_frame_observer.h

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/renderer/render_frame_observer.h

diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h

index 0c8dfed3ae0261e0e6c18203375f7ea7db847c58..7211fdcd334185658fccdb079a15da1fd66a60b1 100644

--- a/content/public/renderer/render_frame_observer.h

+++ b/content/public/renderer/render_frame_observer.h

@@ -19,6 +19,7 @@

#include "v8/include/v8.h"

namespace blink {

+class WebDataSource;

class WebFormElement;

class WebNode;

class WebString;

@@ -62,7 +63,7 @@ class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,

virtual void WillCommitProvisionalLoad() {}

virtual void DidCommitProvisionalLoad(bool is_new_navigation,

bool is_same_page_navigation) {}

- virtual void DidStartProvisionalLoad() {}

+ virtual void DidStartProvisionalLoad(blink::WebDataSource* data_source) {}

virtual void DidFailProvisionalLoad(const blink::WebURLError& error) {}

virtual void DidFinishLoad() {}

virtual void DidFinishDocumentLoad() {}

« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »