components/printing/renderer/print_web_view_helper.h - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/renderer/print_web_view_helper.h

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/printing/renderer/print_web_view_helper.h

diff --git a/components/printing/renderer/print_web_view_helper.h b/components/printing/renderer/print_web_view_helper.h

index 7c1fdbde648ddd2aac02f3c27f74d787c017953f..d979333feb1fd72972fe4109e1afc061f49af2d1 100644

--- a/components/printing/renderer/print_web_view_helper.h

+++ b/components/printing/renderer/print_web_view_helper.h

@@ -171,7 +171,7 @@ class PrintWebViewHelper

// RenderFrameObserver implementation.

void OnDestruct() override;

- void DidStartProvisionalLoad() override;

+ void DidStartProvisionalLoad(blink::WebDataSource* data_source) override;

void DidFailProvisionalLoad(const blink::WebURLError& error) override;

void DidFinishLoad() override;

void ScriptedPrint(bool user_initiated) override;