Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)
Patch Set: Fix test failures. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp b/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
index 67c6163ab52a03be8f2e45be2e5a44e0ae4f1a71..5f461fca2bddf8b702e9aed855006a01b22a3777 100644
--- a/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
@@ -48,14 +48,13 @@ class TestDocumentSubresourceFilter : public WebDocumentSubresourceFilter {
class SubresourceFilteringWebFrameClient
: public FrameTestHelpers::TestWebFrameClient {
public:
- void didStartProvisionalLoad(WebLocalFrame* localFrame) override {
+ void didStartProvisionalLoad(WebDataSource* dataSource) override {
// Normally, the filter should be set when the load is committed. For
// the sake of this test, however, inject it earlier to verify that it
// is not consulted for the main resource load.
m_subresourceFilter =
new TestDocumentSubresourceFilter(m_allowSubresourcesFromNextLoad);
- localFrame->provisionalDataSource()->setSubresourceFilter(
- m_subresourceFilter);
+ dataSource->setSubresourceFilter(m_subresourceFilter);
}
void setAllowSubresourcesFromNextLoad(bool allow) {

Powered by Google App Engine
This is Rietveld 408576698