Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: components/contextual_search/renderer/overlay_js_render_frame_observer.cc

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)
Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/contextual_search/renderer/overlay_js_render_frame_observer .h" 5 #include "components/contextual_search/renderer/overlay_js_render_frame_observer .h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "components/contextual_search/renderer/contextual_search_wrapper.h" 11 #include "components/contextual_search/renderer/contextual_search_wrapper.h"
12 #include "components/contextual_search/renderer/overlay_page_notifier_service_im pl.h" 12 #include "components/contextual_search/renderer/overlay_page_notifier_service_im pl.h"
13 #include "content/public/renderer/render_frame.h" 13 #include "content/public/renderer/render_frame.h"
14 #include "mojo/public/cpp/bindings/strong_binding.h" 14 #include "mojo/public/cpp/bindings/strong_binding.h"
15 #include "services/service_manager/public/cpp/interface_registry.h" 15 #include "services/service_manager/public/cpp/interface_registry.h"
16 #include "v8/include/v8.h" 16 #include "v8/include/v8.h"
17 17
18 namespace contextual_search { 18 namespace contextual_search {
19 19
20 OverlayJsRenderFrameObserver::OverlayJsRenderFrameObserver( 20 OverlayJsRenderFrameObserver::OverlayJsRenderFrameObserver(
21 content::RenderFrame* render_frame) 21 content::RenderFrame* render_frame)
22 : RenderFrameObserver(render_frame), 22 : RenderFrameObserver(render_frame),
23 is_contextual_search_overlay_(false), 23 is_contextual_search_overlay_(false),
24 weak_factory_(this) {} 24 weak_factory_(this) {}
25 25
26 OverlayJsRenderFrameObserver::~OverlayJsRenderFrameObserver() {} 26 OverlayJsRenderFrameObserver::~OverlayJsRenderFrameObserver() {}
27 27
28 void OverlayJsRenderFrameObserver::DidStartProvisionalLoad() { 28 void OverlayJsRenderFrameObserver::DidStartProvisionalLoad(
29 blink::WebDataSource* data_source) {
29 RegisterMojoInterface(); 30 RegisterMojoInterface();
30 } 31 }
31 32
32 void OverlayJsRenderFrameObserver::RegisterMojoInterface() { 33 void OverlayJsRenderFrameObserver::RegisterMojoInterface() {
33 render_frame()->GetInterfaceRegistry()->AddInterface(base::Bind( 34 render_frame()->GetInterfaceRegistry()->AddInterface(base::Bind(
34 &OverlayJsRenderFrameObserver::CreateOverlayPageNotifierService, 35 &OverlayJsRenderFrameObserver::CreateOverlayPageNotifierService,
35 weak_factory_.GetWeakPtr())); 36 weak_factory_.GetWeakPtr()));
36 } 37 }
37 38
38 void OverlayJsRenderFrameObserver::CreateOverlayPageNotifierService( 39 void OverlayJsRenderFrameObserver::CreateOverlayPageNotifierService(
(...skipping 28 matching lines...) Expand all
67 ->RemoveInterface<mojom::OverlayPageNotifierService>(); 68 ->RemoveInterface<mojom::OverlayPageNotifierService>();
68 } 69 }
69 } 70 }
70 71
71 void OverlayJsRenderFrameObserver::OnDestruct() { 72 void OverlayJsRenderFrameObserver::OnDestruct() {
72 DestroyOverlayPageNotifierService(); 73 DestroyOverlayPageNotifierService();
73 delete this; 74 delete this;
74 } 75 }
75 76
76 } // namespace contextual_search 77 } // namespace contextual_search
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698