Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)
Patch Set: Add comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 6163 matching lines...) Expand 10 before | Expand all | Expand 10 after
6174 if (request_params.should_clear_history_list) { 6174 if (request_params.should_clear_history_list) {
6175 CHECK_EQ(-1, render_view_->history_list_offset_); 6175 CHECK_EQ(-1, render_view_->history_list_offset_);
6176 CHECK_EQ(0, render_view_->history_list_length_); 6176 CHECK_EQ(0, render_view_->history_list_length_);
6177 } 6177 }
6178 } 6178 }
6179 6179
6180 void RenderFrameImpl::BeginNavigation(const NavigationPolicyInfo& info) { 6180 void RenderFrameImpl::BeginNavigation(const NavigationPolicyInfo& info) {
6181 CHECK(IsBrowserSideNavigationEnabled()); 6181 CHECK(IsBrowserSideNavigationEnabled());
6182 browser_side_navigation_pending_ = true; 6182 browser_side_navigation_pending_ = true;
6183 6183
6184 didStartProvisionalLoad(frame_);
6185
6184 // Note: At this stage, the goal is to apply all the modifications the 6186 // Note: At this stage, the goal is to apply all the modifications the
6185 // renderer wants to make to the request, and then send it to the browser, so 6187 // renderer wants to make to the request, and then send it to the browser, so
6186 // that the actual network request can be started. Ideally, all such 6188 // that the actual network request can be started. Ideally, all such
6187 // modifications should take place in willSendRequest, and in the 6189 // modifications should take place in willSendRequest, and in the
6188 // implementation of willSendRequest for the various InspectorAgents 6190 // implementation of willSendRequest for the various InspectorAgents
6189 // (devtools). 6191 // (devtools).
6190 // 6192 //
6191 // TODO(clamy): Apply devtools override. 6193 // TODO(clamy): Apply devtools override.
6192 // TODO(clamy): Make sure that navigation requests are not modified somewhere 6194 // TODO(clamy): Make sure that navigation requests are not modified somewhere
6193 // else in blink. 6195 // else in blink.
(...skipping 619 matching lines...) Expand 10 before | Expand all | Expand 10 after
6813 // event target. Potentially a Pepper plugin will receive the event. 6815 // event target. Potentially a Pepper plugin will receive the event.
6814 // In order to tell whether a plugin gets the last mouse event and which it 6816 // In order to tell whether a plugin gets the last mouse event and which it
6815 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets 6817 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
6816 // the event, it will notify us via DidReceiveMouseEvent() and set itself as 6818 // the event, it will notify us via DidReceiveMouseEvent() and set itself as
6817 // |pepper_last_mouse_event_target_|. 6819 // |pepper_last_mouse_event_target_|.
6818 pepper_last_mouse_event_target_ = nullptr; 6820 pepper_last_mouse_event_target_ = nullptr;
6819 #endif 6821 #endif
6820 } 6822 }
6821 6823
6822 } // namespace content 6824 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698