Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2661623002: Test for ddc async call timing (Closed)

Created:
3 years, 10 months ago by vsm
Modified:
3 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test for ddc async call timing Forgot to add this to the last CL. R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/093c607092bc1859697eda5a8f7f8ec5a8e65a4e

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
A tests/language_strong/async_call_test.dart View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 10 months ago (2017-01-27 13:57:22 UTC) #3
Jennifer Messerly
lgtm https://codereview.chromium.org/2661623002/diff/1/tests/language_strong/async_call_test.dart File tests/language_strong/async_call_test.dart (right): https://codereview.chromium.org/2661623002/diff/1/tests/language_strong/async_call_test.dart#newcode1 tests/language_strong/async_call_test.dart:1: // Copyright (c) 2015, the Dart project authors. ...
3 years, 10 months ago (2017-01-29 09:10:59 UTC) #4
vsm
3 years, 10 months ago (2017-01-30 13:47:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
093c607092bc1859697eda5a8f7f8ec5a8e65a4e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698