telemetry/telemetry/value/trace_unittest.py - Issue 2661573003: Refactor TraceData to encapsulate internal traces' representation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/value/trace_unittest.py

Issue 2661573003: Refactor TraceData to encapsulate internal traces' representation (Closed)

Patch Set: Address Charlie's comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/value/trace_unittest.py

diff --git a/telemetry/telemetry/value/trace_unittest.py b/telemetry/telemetry/value/trace_unittest.py

index 47f0e8b3a5d22bdbcdc4980e0a93461c08a834ae..be0da0566c0a6faae20a6f7877e1d5894b484bb8 100644

--- a/telemetry/telemetry/value/trace_unittest.py

+++ b/telemetry/telemetry/value/trace_unittest.py

@@ -140,7 +140,6 @@ class ValueTest(TestBase):

for f in trace_files:

with open(f, 'r') as trace_file:

d = trace_file.read()

- print d

if d == raw_data['powerTraceAsString']:

self.assertFalse(battor_seen)

battor_seen = True

@@ -158,7 +157,6 @@ class ValueTest(TestBase):

os.remove(v.filename)

def _IsEmptyDir(path):

return os.path.exists(path) and not os.listdir(path)