telemetry/telemetry/page/page_run_end_to_end_unittest.py - Issue 2661573003: Refactor TraceData to encapsulate internal traces' representation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/page/page_run_end_to_end_unittest.py

Issue 2661573003: Refactor TraceData to encapsulate internal traces' representation (Closed)

Patch Set: Address Charlie's comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/page/page_run_end_to_end_unittest.py

diff --git a/telemetry/telemetry/page/page_run_end_to_end_unittest.py b/telemetry/telemetry/page/page_run_end_to_end_unittest.py

index dcb354aac6853a35b1239ddb7f211bbef4a3bb5f..bed1caaeff3e288074f0965afa86fff169e30ded 100644

--- a/telemetry/telemetry/page/page_run_end_to_end_unittest.py

+++ b/telemetry/telemetry/page/page_run_end_to_end_unittest.py

@@ -565,7 +565,7 @@ class ActualPageRunEndToEndTests(unittest.TestCase):

self.assertEquals(0, len(results.failures))

self.assertEquals(0, len(results.all_page_specific_values))

self.assertTrue(os.path.isfile(

- os.path.join(options.output_dir, 'blank_html.zip')))

+ os.path.join(options.output_dir, 'blank_html.html')))

finally:

shutil.rmtree(options.output_dir)