Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py

Issue 2661573003: Refactor TraceData to encapsulate internal traces' representation (Closed)
Patch Set: Address Charlie's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/internal/platform/profiler/trace_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py
diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py b/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py
index 06ddeb75cab1c481e1575a1ea89377abdc0ca448..51bae8dd05522d50e3575b03b4a9f75ae89c1323 100644
--- a/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py
+++ b/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py
@@ -4,7 +4,6 @@
import timeit
import unittest
-import json
from telemetry import decorators
from telemetry.internal.backends.chrome_inspector import tracing_backend
@@ -68,10 +67,7 @@ class TracingBackendTest(tab_test_case.TabTestCase):
# Check that clock sync data is in tracing data.
clock_sync_found = False
- trace_handles = tracing_data.GetTracesFor(trace_data.CHROME_TRACE_PART)
- self.assertEqual(len(trace_handles), 1)
- with open(trace_handles[0].file_path) as f:
- trace = json.load(f)
+ trace = tracing_data.GetTraceFor(trace_data.CHROME_TRACE_PART)
for event in trace['traceEvents']:
if event['name'] == 'clock_sync' or 'ClockSyncEvent' in event['name']:
clock_sync_found = True
@@ -128,14 +124,7 @@ class TracingBackendUnittest(unittest.TestCase):
trace_data.CHROME_TRACE_PART)
traces = []
for d in data:
- if isinstance(d, trace_data.TraceFileHandle):
- try:
- with open(d.file_path) as f:
- traces.append(json.load(f))
- finally:
- d.Clean()
- else:
- traces.append(d)
+ traces.append(d)
return traces
def testCollectTracingDataTimeout(self):
« no previous file with comments | « no previous file | telemetry/telemetry/internal/platform/profiler/trace_profiler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698