Introduce the concept of web schemes capable of storage

chrome/browser/browsing_data/browsing_data_helper_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_helper.h"
 
 #include "base/macros.h"
 #include "chrome/common/url_constants.h"
 #include "extensions/common/constants.h"
 #include "extensions/features/features.h"
@@ skipping 43 matching lines @@
   bool Match(const GURL& origin,
              int mask,
              storage::SpecialStoragePolicy* policy) {
     return BrowsingDataHelper::DoesOriginMatchMask(origin, mask, policy);
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowsingDataHelperTest);
 };
 
-TEST_F(BrowsingDataHelperTest, WebSafeSchemesAreWebSafe) {
+TEST_F(BrowsingDataHelperTest, WebStorageSchemesAreWebSchemes) {
   EXPECT_TRUE(IsWebScheme(url::kHttpScheme));
   EXPECT_TRUE(IsWebScheme(url::kHttpsScheme));
+  EXPECT_TRUE(IsWebScheme(url::kFileScheme));
   EXPECT_TRUE(IsWebScheme(url::kFtpScheme));
-  EXPECT_TRUE(IsWebScheme(url::kDataScheme));
-  EXPECT_TRUE(IsWebScheme("feed"));
-  EXPECT_TRUE(IsWebScheme(url::kBlobScheme));
-  EXPECT_TRUE(IsWebScheme(url::kFileSystemScheme));
-  EXPECT_FALSE(IsWebScheme("invalid-scheme-i-just-made-up"));
+  EXPECT_TRUE(IsWebScheme(url::kWsScheme));
+  EXPECT_TRUE(IsWebScheme(url::kWssScheme));
 }
 
-TEST_F(BrowsingDataHelperTest, ChromeSchemesAreNotWebSafe) {
+TEST_F(BrowsingDataHelperTest, ChromeSchemesAreNotWebSchemes) {
   EXPECT_FALSE(IsWebScheme(extensions::kExtensionScheme));
   EXPECT_FALSE(IsWebScheme(url::kAboutScheme));
   EXPECT_FALSE(IsWebScheme(content::kChromeDevToolsScheme));
   EXPECT_FALSE(IsWebScheme(content::kChromeUIScheme));
   EXPECT_FALSE(IsWebScheme(url::kJavaScriptScheme));
   EXPECT_FALSE(IsWebScheme(url::kMailToScheme));
   EXPECT_FALSE(IsWebScheme(content::kViewSourceScheme));
 }
 
-TEST_F(BrowsingDataHelperTest, WebSafeSchemesAreNotExtensions) {
+TEST_F(BrowsingDataHelperTest, WebStorageSchemesAreNotExtensions) {
   EXPECT_FALSE(IsExtensionScheme(url::kHttpScheme));
   EXPECT_FALSE(IsExtensionScheme(url::kHttpsScheme));
+  EXPECT_FALSE(IsExtensionScheme(url::kFileScheme));
   EXPECT_FALSE(IsExtensionScheme(url::kFtpScheme));
-  EXPECT_FALSE(IsExtensionScheme(url::kDataScheme));
-  EXPECT_FALSE(IsExtensionScheme("feed"));
-  EXPECT_FALSE(IsExtensionScheme(url::kBlobScheme));
-  EXPECT_FALSE(IsExtensionScheme(url::kFileSystemScheme));
-  EXPECT_FALSE(IsExtensionScheme("invalid-scheme-i-just-made-up"));
+  EXPECT_FALSE(IsExtensionScheme(url::kWsScheme));
+  EXPECT_FALSE(IsExtensionScheme(url::kWssScheme));
 }
 
 TEST_F(BrowsingDataHelperTest, ChromeSchemesAreNotAllExtension) {
   EXPECT_TRUE(IsExtensionScheme(extensions::kExtensionScheme));
 
   EXPECT_FALSE(IsExtensionScheme(url::kAboutScheme));
   EXPECT_FALSE(IsExtensionScheme(content::kChromeDevToolsScheme));
   EXPECT_FALSE(IsExtensionScheme(content::kChromeUIScheme));
   EXPECT_FALSE(IsExtensionScheme(url::kJavaScriptScheme));
   EXPECT_FALSE(IsExtensionScheme(url::kMailToScheme));
   EXPECT_FALSE(IsExtensionScheme(content::kViewSourceScheme));
 }
 
+TEST_F(BrowsingDataHelperTest, SchemesThatCantStoreDataDontMatchAnything) {
+  EXPECT_FALSE(IsWebScheme(url::kDataScheme));
+  EXPECT_FALSE(IsExtensionScheme(url::kDataScheme));
+
+  EXPECT_FALSE(IsWebScheme("feed"));
+  EXPECT_FALSE(IsExtensionScheme("feed"));
+
+  EXPECT_FALSE(IsWebScheme(url::kBlobScheme));
+  EXPECT_FALSE(IsExtensionScheme(url::kBlobScheme));
+
+  EXPECT_FALSE(IsWebScheme(url::kFileSystemScheme));
+  EXPECT_FALSE(IsExtensionScheme(url::kFileSystemScheme));
+
+  EXPECT_FALSE(IsWebScheme("invalid-scheme-i-just-made-up"));
+  EXPECT_FALSE(IsExtensionScheme("invalid-scheme-i-just-made-up"));
+}
+
 #if BUILDFLAG(ENABLE_EXTENSIONS)
 TEST_F(BrowsingDataHelperTest, TestMatches) {
   scoped_refptr<MockExtensionSpecialStoragePolicy> mock_policy =
       new MockExtensionSpecialStoragePolicy;
   // Protect kOrigin1.
   mock_policy->AddProtected(kOrigin1.GetOrigin());
 
   EXPECT_FALSE(Match(kOrigin1, kUnprotected, mock_policy.get()));
   EXPECT_TRUE(Match(kOrigin2, kUnprotected, mock_policy.get()));
   EXPECT_FALSE(Match(kOriginExt, kUnprotected, mock_policy.get()));
@@ skipping 48 matching lines @@
   EXPECT_TRUE(Match(kOriginExt, kExtension, nullptr));
   EXPECT_FALSE(Match(kOriginExt, kUnprotected, nullptr));
   EXPECT_FALSE(Match(kOriginExt, kProtected, nullptr));
 
   EXPECT_FALSE(Match(kOriginDevTools, kExtension, nullptr));
   EXPECT_FALSE(Match(kOriginDevTools, kUnprotected, nullptr));
   EXPECT_FALSE(Match(kOriginDevTools, kProtected, nullptr));
 }
 
 }  // namespace