chrome/browser/resources/settings/controls/settings_toggle_button.html - Issue 2661533002: MD Settings: fix settings-toggle-button label text overflow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/settings_toggle_button.html

Issue 2661533002: MD Settings: fix settings-toggle-button label text overflow. (Closed)

Patch Set: do text-elide and no-min-width in a cleaner way Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/appearance_page/appearance_page.html ('k') | chrome/browser/resources/settings/controls/settings_toggle_button.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/controls/settings_toggle_button.html

diff --git a/chrome/browser/resources/settings/controls/settings_toggle_button.html b/chrome/browser/resources/settings/controls/settings_toggle_button.html

index fc96b83bbdfbedd3ca22e84ca593f96f75f17acf..add7e52112f991a3e92d1f5697c05dd498a709df 100644

--- a/chrome/browser/resources/settings/controls/settings_toggle_button.html

+++ b/chrome/browser/resources/settings/controls/settings_toggle_button.html

@@ -6,6 +6,16 @@

<dom-module id="settings-toggle-button">

+ :host([elide-label]),

+ :host([elide-label]) #outerRow,

+ :host([elide-label]) #outerRow > div.flex {

+ min-width: 0;

+ }

+ :host([elide-label]) .label {

+ @apply(--settings-text-elide);

+ }

#outerRow {

align-items: center;

display: flex;

@@ -29,8 +39,8 @@

<div class="flex" on-tap="onLabelWrapperTap_"

actionable$="[[!controlDisabled_(disabled, pref)]]">

- <div>[[label]]</div>

- <div class="secondary">[[subLabel]]</div>

+ <div class="label">[[label]]</div>

+ <div class="secondary label">[[subLabel]]</div>

</div>