Issue 266153002: Port ui_base_jni_headers target to GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 266153002: Port ui_base_jni_headers target to GN build. (Closed)

Created:
6 years, 7 months ago by tfarina

Modified:
6 years, 7 months ago

Reviewers:
cjhopman, brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Port ui_base_jni_headers target to GN build. In Debug build: $ gn gen out/Debug --args='os="android" cpu_arch="x86"' $ ninja -C out/Debug ui_base_jni_headers In Release build: $ gn gen out/Debug --args='is_debug=false os="android" cpu_arch="x86"' $ ninja -C out/Release ui_base_jni_headers BUG=None TEST=see above R=brettw@chromium.org TBR=ben Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269544

Patch Set 1 #

Total comments: 2

Patch Set 2 : enable deps #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	ui/base/BUILD.gn	View	1	3 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

brettw

https://codereview.chromium.org/266153002/diff/1/ui/base/BUILD.gn File ui/base/BUILD.gn (left): https://codereview.chromium.org/266153002/diff/1/ui/base/BUILD.gn#oldcode474 ui/base/BUILD.gn:474: #":ui_base_jni_headers", I think you can uncomment this now.

6 years, 7 months ago (2014-05-05 17:16:12 UTC) #2

tfarina

6 years, 7 months ago (2014-05-05 17:57:06 UTC) #3

tfarina

6 years, 7 months ago (2014-05-10 06:26:01 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r269544 (presubmit successful).

Expand Messages | Collapse Messages