VTVDA: Optimize pic_order_cnt_type == 2.

media/video/h264_poc_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include "base/files/file_path.h"
 #include "base/files/memory_mapped_file.h"
 #include "base/macros.h"
 #include "media/base/test_data_util.h"
 #include "media/filters/h264_parser.h"
 #include "media/video/h264_poc.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace media {
 
 class H264POCTest : public testing::Test {
  public:
   H264POCTest() : sps_(), slice_hdr_() {
     // Default every frame to be a reference frame.
     slice_hdr_.nal_ref_idc = 1;
   }
 
  protected:
   bool ComputePOC() {
-    return h264_poc_.ComputePicOrderCnt(&sps_, slice_hdr_, &poc_);
+    bool result = h264_poc_.ComputePicOrderCnt(&sps_, slice_hdr_, &poc_);
+
+    // Clear MMCO5.
+    slice_hdr_.adaptive_ref_pic_marking_mode_flag = false;
+    slice_hdr_.ref_pic_marking[0].memory_mgmnt_control_operation = 0;
+    slice_hdr_.ref_pic_marking[1].memory_mgmnt_control_operation = 0;
+    slice_hdr_.ref_pic_marking[2].memory_mgmnt_control_operation = 0;
+
+    return result;
   }
 
   // Also sets as a reference frame and unsets IDR, which is required for
   // memory management control operations to be parsed.
   void SetMMCO5() {
     slice_hdr_.nal_ref_idc = 1;
     slice_hdr_.idr_pic_flag = false;
     slice_hdr_.adaptive_ref_pic_marking_mode_flag = true;
     slice_hdr_.ref_pic_marking[0].memory_mgmnt_control_operation = 6;
     slice_hdr_.ref_pic_marking[1].memory_mgmnt_control_operation = 5;
@@ skipping 61 matching lines @@
   slice_hdr_.frame_num = 2;
   slice_hdr_.pic_order_cnt_lsb = 0;
   ASSERT_TRUE(ComputePOC());
   ASSERT_EQ(16, poc_);
 
   slice_hdr_.frame_num = 3;
   slice_hdr_.pic_order_cnt_lsb = 8;
   ASSERT_TRUE(ComputePOC());
   ASSERT_EQ(24, poc_);
 
+  // MMCO5 resets to 0.
   slice_hdr_.frame_num = 4;
   slice_hdr_.pic_order_cnt_lsb = 0;
   SetMMCO5();
   ASSERT_TRUE(ComputePOC());
-  ASSERT_EQ(32, poc_);
+  ASSERT_EQ(0, poc_);
 
-  // Due to the MMCO5 above, this is relative to 0, but also detected as
-  // positive wrapping.
+  // Still detected as positive wrapping.
   slice_hdr_.frame_num = 5;
   slice_hdr_.pic_order_cnt_lsb = 8;
   ASSERT_TRUE(ComputePOC());
   ASSERT_EQ(24, poc_);
 }
 
 TEST_F(H264POCTest, PicOrderCntType1) {
   sps_.pic_order_cnt_type = 1;
   sps_.log2_max_frame_num_minus4 = 0;  // 16
   sps_.num_ref_frames_in_pic_order_cnt_cycle = 2;
@@ skipping 51 matching lines @@
   // Ref frame.
   slice_hdr_.idr_pic_flag = false;
   slice_hdr_.frame_num = 1;
   ASSERT_TRUE(ComputePOC());
   ASSERT_EQ(1, poc_);
 
   // Ref frame, detected as wrapping.
   SetMMCO5();
   slice_hdr_.frame_num = 0;
   ASSERT_TRUE(ComputePOC());
-  ASSERT_EQ(24, poc_);
+  ASSERT_EQ(0, poc_);
 
   // Ref frame, wrapping from before has been cleared.
   slice_hdr_.frame_num = 1;
   ASSERT_TRUE(ComputePOC());
   ASSERT_EQ(1, poc_);
 }
 
-// Despite being invalid, videos with duplicate non-keyframe |frame_num| values
-// are common. http://crbug.com/615289, http://crbug.com/616349.
+// |frame_num| values may be duplicated by non-reference frames.
 TEST_F(H264POCTest, PicOrderCntType1_DupFrameNum) {
   sps_.pic_order_cnt_type = 1;
   sps_.log2_max_frame_num_minus4 = 0;  // 16
   sps_.num_ref_frames_in_pic_order_cnt_cycle = 2;
   sps_.expected_delta_per_pic_order_cnt_cycle = 3;
   sps_.offset_for_ref_frame[0] = 1;
   sps_.offset_for_ref_frame[1] = 2;
 
   // Initial IDR with POC 0.
   slice_hdr_.idr_pic_flag = true;
   slice_hdr_.frame_num = 0;
   ASSERT_TRUE(ComputePOC());
   ASSERT_EQ(0, poc_);
 
   // Ref frame.
   slice_hdr_.idr_pic_flag = false;
   slice_hdr_.frame_num = 1;
   ASSERT_TRUE(ComputePOC());
   ASSERT_EQ(1, poc_);
 
   // Duplicate |frame_num| frame.
+  slice_hdr_.nal_ref_idc = 0;
   slice_hdr_.frame_num = 1;
-  slice_hdr_.delta_pic_order_cnt0 = 1;
+  slice_hdr_.delta_pic_order_cnt0 = 2;
   ASSERT_TRUE(ComputePOC());
   ASSERT_EQ(2, poc_);
 }
 
 TEST_F(H264POCTest, PicOrderCntType2) {
   sps_.pic_order_cnt_type = 2;
 
   // Initial IDR with POC 0.
   slice_hdr_.idr_pic_flag = true;
   slice_hdr_.frame_num = 0;
@@ skipping 39 matching lines @@
   // Ref frame.
   slice_hdr_.idr_pic_flag = false;
   slice_hdr_.frame_num = 1;
   ASSERT_TRUE(ComputePOC());
   ASSERT_EQ(2, poc_);
 
   // Ref frame, detected as wrapping.
   SetMMCO5();
   slice_hdr_.frame_num = 0;
   ASSERT_TRUE(ComputePOC());
-  ASSERT_EQ(32, poc_);
+  ASSERT_EQ(0, poc_);
 
   // Ref frame, wrapping from before has been cleared.
   slice_hdr_.frame_num = 1;
   ASSERT_TRUE(ComputePOC());
   ASSERT_EQ(2, poc_);
 }
 
 }  // namespace media