Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.cpp

Issue 2661323002: Implement CSSPaintValue and add a layout test. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/csspaint/CSSPaintImageGeneratorImpl.h" 5 #include "modules/csspaint/CSSPaintImageGeneratorImpl.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/frame/LocalDOMWindow.h" 8 #include "core/frame/LocalDOMWindow.h"
9 #include "modules/csspaint/CSSPaintDefinition.h" 9 #include "modules/csspaint/CSSPaintDefinition.h"
10 #include "modules/csspaint/PaintWorklet.h" 10 #include "modules/csspaint/PaintWorklet.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 ASSERT(!m_definition); 45 ASSERT(!m_definition);
46 m_definition = definition; 46 m_definition = definition;
47 47
48 ASSERT(m_observer); 48 ASSERT(m_observer);
49 m_observer->paintImageGeneratorReady(); 49 m_observer->paintImageGeneratorReady();
50 } 50 }
51 51
52 PassRefPtr<Image> CSSPaintImageGeneratorImpl::paint( 52 PassRefPtr<Image> CSSPaintImageGeneratorImpl::paint(
53 const LayoutObject& layoutObject, 53 const LayoutObject& layoutObject,
54 const IntSize& size, 54 const IntSize& size,
55 float zoom) { 55 float zoom,
56 return m_definition ? m_definition->paint(layoutObject, size, zoom) : nullptr; 56 const CSSStyleValueVector* data) {
57 return m_definition ? m_definition->paint(layoutObject, size, zoom, data)
58 : nullptr;
57 } 59 }
58 60
59 const Vector<CSSPropertyID>& 61 const Vector<CSSPropertyID>&
60 CSSPaintImageGeneratorImpl::nativeInvalidationProperties() const { 62 CSSPaintImageGeneratorImpl::nativeInvalidationProperties() const {
61 DEFINE_STATIC_LOCAL(Vector<CSSPropertyID>, emptyVector, ()); 63 DEFINE_STATIC_LOCAL(Vector<CSSPropertyID>, emptyVector, ());
62 return m_definition ? m_definition->nativeInvalidationProperties() 64 return m_definition ? m_definition->nativeInvalidationProperties()
63 : emptyVector; 65 : emptyVector;
64 } 66 }
65 67
66 const Vector<AtomicString>& 68 const Vector<AtomicString>&
67 CSSPaintImageGeneratorImpl::customInvalidationProperties() const { 69 CSSPaintImageGeneratorImpl::customInvalidationProperties() const {
68 DEFINE_STATIC_LOCAL(Vector<AtomicString>, emptyVector, ()); 70 DEFINE_STATIC_LOCAL(Vector<AtomicString>, emptyVector, ());
69 return m_definition ? m_definition->customInvalidationProperties() 71 return m_definition ? m_definition->customInvalidationProperties()
70 : emptyVector; 72 : emptyVector;
71 } 73 }
72 74
73 bool CSSPaintImageGeneratorImpl::hasAlpha() const { 75 bool CSSPaintImageGeneratorImpl::hasAlpha() const {
74 return m_definition && m_definition->hasAlpha(); 76 return m_definition && m_definition->hasAlpha();
75 } 77 }
76 78
79 const Vector<CSSSyntaxDescriptor>&
80 CSSPaintImageGeneratorImpl::inputArgumentTypes() const {
81 DEFINE_STATIC_LOCAL(Vector<CSSSyntaxDescriptor>, emptyVector, ());
haraken 2017/02/21 23:51:55 Nit: Is it really worth defining an empty vector?
renjieliu1 2017/02/22 04:47:54 the compiler will throw me an error says returning
82 return m_definition ? m_definition->inputArgumentTypes() : emptyVector;
83 }
84
77 DEFINE_TRACE(CSSPaintImageGeneratorImpl) { 85 DEFINE_TRACE(CSSPaintImageGeneratorImpl) {
78 visitor->trace(m_definition); 86 visitor->trace(m_definition);
79 visitor->trace(m_observer); 87 visitor->trace(m_observer);
80 CSSPaintImageGenerator::trace(visitor); 88 CSSPaintImageGenerator::trace(visitor);
81 } 89 }
82 90
83 } // namespace blink 91 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698