Add extra DCHECKing to try to catch subpixel rendering on a non-opaque

ui/views/controls/label.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/label.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <cmath>
@@ skipping 12 matching lines @@
 #include "ui/base/cursor/cursor.h"
 #include "ui/base/default_style.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/geometry/insets.h"
 #include "ui/gfx/text_elider.h"
 #include "ui/native_theme/native_theme.h"
 #include "ui/strings/grit/ui_strings.h"
+#include "ui/views/background.h"
 #include "ui/views/controls/menu/menu_runner.h"
 #include "ui/views/focus/focus_manager.h"
 #include "ui/views/native_cursor.h"
 #include "ui/views/selection_controller.h"
 
 namespace views {
 // static
 const char Label::kViewClassName[] = "Label";
 const int Label::kFocusBorderPadding = 1;
 
@@ skipping 400 matching lines @@
   render_text->SetMinLineHeight(line_height());
   render_text->SetFontList(font_list());
   render_text->set_shadows(shadows());
   render_text->SetCursorEnabled(false);
   render_text->SetText(text);
   return render_text;
 }
 
 void Label::PaintText(gfx::Canvas* canvas) {
   MaybeBuildRenderTextLines();
+
   for (size_t i = 0; i < lines_.size(); ++i)
     lines_[i]->Draw(canvas);
+
+#if DCHECK_IS_ON()

[msw, 2017/02/11 00:49:37]

optional nit: it might be nice to have this as a separate anon-namespace
function, instead of inlined in PaintText; especially if anyone tries to
later-on add code below this bloc; and miss the debug-only early return.

[Evan Stade, 2017/02/11 01:42:37]

I share your concern about the unnoticed early return, which is why I didn't
have it originally, but moving to an anon namespace is annoying given the access
to member variables.

+  // Attempt to ensure that if we're using subpixel rendering, we're painting
+  // to an opaque background. What we don't want to find is an ancestor in the
+  // hierarchy that paints to a non-opaque layer.
+  if (lines_.empty() || lines_[0]->subpixel_rendering_suppressed())
+    return;
+
+  for (View* view = this; view; view = view->parent()) {
+    if (view->background() &&
+        SkColorGetA(view->background()->get_color()) == SK_AlphaOPAQUE)
+      break;
+
+    if (view->layer()) {
+      DCHECK(view->layer()->fills_bounds_opaquely())
+          << " Ancestor view has a non-opaque layer: " << view->GetClassName()
+          << " with ID " << view->id();
+      break;
+    }
+  }
+#endif
 }
 
 void Label::OnBoundsChanged(const gfx::Rect& previous_bounds) {
   if (previous_bounds.size() != size())
     InvalidateLayout();
 }
 
 void Label::OnPaint(gfx::Canvas* canvas) {
   View::OnPaint(canvas);
   if (is_first_paint_text_) {
@@ skipping 507 matching lines @@
                                           selection_background_color_)
           : requested_selection_text_color_;
 
   ApplyTextColors();
   SchedulePaint();
 }
 
 void Label::ApplyTextColors() const {
   SkColor color = enabled() ? actual_enabled_color_ : actual_disabled_color_;
   bool subpixel_rendering_suppressed =
-      SkColorGetA(background_color_) != 0xFF || !subpixel_rendering_enabled_;
+      SkColorGetA(background_color_) != SK_AlphaOPAQUE ||
+      !subpixel_rendering_enabled_;
   for (size_t i = 0; i < lines_.size(); ++i) {
     lines_[i]->SetColor(color);
     lines_[i]->set_selection_color(actual_selection_text_color_);
     lines_[i]->set_selection_background_focused_color(
         selection_background_color_);
     lines_[i]->set_subpixel_rendering_suppressed(subpixel_rendering_suppressed);
   }
 }
 
 void Label::UpdateColorsFromTheme(const ui::NativeTheme* theme) {
@@ skipping 54 matching lines @@
       .WriteText(GetSelectedText());
 }
 
 void Label::BuildContextMenuContents() {
   context_menu_contents_.AddItemWithStringId(IDS_APP_COPY, IDS_APP_COPY);
   context_menu_contents_.AddItemWithStringId(IDS_APP_SELECT_ALL,
                                              IDS_APP_SELECT_ALL);
 }
 
 }  // namespace views