Fix errors and warnings

Fix errors and warnings

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/efd28ece970e08280c62cca78382d28e9b9cde09

[Brian Wilkerson, 2017-01-31 16:48:53]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2017-01-31 16:48:54]

This will need to wait until Bill has fixed an issue with the dartk build, but
I'd like to get it reviewed.

[scheglov, 2017-01-31 17:15:38]

LGTM

[Brian Wilkerson, 2017-02-01 16:06:34]

Description was changed from

==========
Fix errors and warnings
==========

to

==========
Fix errors and warnings

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/efd28ece970e08280c62cca78382d28e9b9cde09
==========

[Brian Wilkerson, 2017-02-01 16:06:36]

Committed patchset #1 (id:1) manually as
efd28ece970e08280c62cca78382d28e9b9cde09 (presubmit successful).

[Paul Berry, 2017-02-01 16:49:52]

paulberry@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2017-02-01 16:49:53]

https://codereview.chromium.org/2661263002/diff/1/pkg/analyzer/lib/src/cancel...
File pkg/analyzer/lib/src/cancelable_future.dart (right):

https://codereview.chromium.org/2661263002/diff/1/pkg/analyzer/lib/src/cancel...
pkg/analyzer/lib/src/cancelable_future.dart:255: Future/*<S>*/
then/*<S>*/(FutureOr<S> onValue(T value), {Function onError}) =>
Needs to be "/*<S>*/" to avoid errors in spec mode.  This is breaking the
analyzer bot.

https://codereview.chromium.org/2661263002/diff/1/pkg/analyzer/lib/src/cancel...
pkg/analyzer/lib/src/cancelable_future.dart:291: Future/*<S>*/
then/*<S>*/(FutureOr<S> onValue(T value), {Function onError}) =>
Same here.

[Brian Wilkerson, 2017-02-01 17:04:54]

https://codereview.chromium.org/2661263002/diff/1/pkg/analyzer/lib/src/cancel...
File pkg/analyzer/lib/src/cancelable_future.dart (right):

https://codereview.chromium.org/2661263002/diff/1/pkg/analyzer/lib/src/cancel...
pkg/analyzer/lib/src/cancelable_future.dart:255: Future/*<S>*/
then/*<S>*/(FutureOr<S> onValue(T value), {Function onError}) =>
Saw that, thanks. CL is out.