Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: appengine/swarming/server/bot_management_test.py

Issue 2661173004: Make deleted bots still show up when searched for by id (Closed)
Patch Set: Don't forget MP stuff Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/server/bot_management_test.py
diff --git a/appengine/swarming/server/bot_management_test.py b/appengine/swarming/server/bot_management_test.py
index b1e4f6490c96a3b5580a962d3ef6ba2108f7ddc5..18d5c65d1ffe0a92e6bd7ec6400bf1e12a3ca234 100755
--- a/appengine/swarming/server/bot_management_test.py
+++ b/appengine/swarming/server/bot_management_test.py
@@ -45,8 +45,9 @@ class BotManagementTest(test_case.TestCase):
task_name=None)
expected = {
- 'authenticated_as': 'bot:id1.domain',
+ 'authenticated_as': u'bot:id1.domain',
'composite': [8, 2],
+ 'deleted': False,
'dimensions': {u'foo': [u'bar'], u'id': [u'id1']},
'external_ip': u'8.8.4.4',
'first_seen_ts': now,
@@ -75,7 +76,7 @@ class BotManagementTest(test_case.TestCase):
task_name=None)
expected = [
{
- 'authenticated_as': 'bot:id1.domain',
+ 'authenticated_as': u'bot:id1.domain',
'dimensions': {u'foo': [u'bar'], u'id': [u'id1']},
'event_type': u'bot_connected',
'external_ip': u'8.8.4.4',
@@ -106,8 +107,9 @@ class BotManagementTest(test_case.TestCase):
# Assert that BotInfo was updated too.
expected = {
- 'authenticated_as': 'bot:id1.domain',
+ 'authenticated_as': u'bot:id1.domain',
'composite': [4, 2],
+ 'deleted': False,
'dimensions': {u'foo': [u'bar'], u'id': [u'id1']},
'external_ip': u'8.8.4.4',
'first_seen_ts': now,
@@ -139,8 +141,9 @@ class BotManagementTest(test_case.TestCase):
task_name='yo')
expected = {
- 'authenticated_as': 'bot:id1.domain',
+ 'authenticated_as': u'bot:id1.domain',
'composite': [8, 1],
+ 'deleted': False,
'dimensions': {u'foo': [u'bar'], u'id': [u'id1']},
'external_ip': u'8.8.4.4',
'first_seen_ts': now,
@@ -160,7 +163,7 @@ class BotManagementTest(test_case.TestCase):
expected = [
{
- 'authenticated_as': 'bot:id1.domain',
+ 'authenticated_as': u'bot:id1.domain',
'dimensions': {u'foo': [u'bar'], u'id': [u'id1']},
'event_type': u'request_task',
'external_ip': u'8.8.4.4',

Powered by Google App Engine
This is Rietveld 408576698