Make deleted bots still show up when searched for by id

appengine/swarming/message_conversion.py

 # Copyright 2015 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """This module facilitates conversion from dictionaries to ProtoRPC messages.
 
 Given a dictionary whose keys' names and values' types comport with the
 fields defined for a protorpc.messages.Message subclass, this module tries to
 generate a Message instance that corresponds to the provided dictionary. The
 "normal" use case is for ndb.Models which need to be represented as a
@@ skipping 52 matching lines @@
   Returns None when input is 0 or None.
   """
   if not value:
     return None
   try:
     return utils.timestamp_to_datetime(value*1000000.)
   except OverflowError as e:
     raise ValueError(e)
 
 
-def bot_info_to_rpc(entity, now):
+def bot_info_to_rpc(entity, now, deleted=False):
   """"Returns a swarming_rpcs.BotInfo from a bot.BotInfo."""
   return _ndb_to_rpc(
       swarming_rpcs.BotInfo,
       entity,
       dimensions=_string_list_pairs_from_dict(entity.dimensions),
       is_dead=entity.is_dead(now),
       bot_id=entity.id,
+      deleted=deleted,
       state=json.dumps(entity.state, sort_keys=True, separators=(',', ':')))
 
 
 def bot_event_to_rpc(entity):
   """"Returns a swarming_rpcs.BotEvent from a bot.BotEvent."""
   return _ndb_to_rpc(
       swarming_rpcs.BotEvent,
       entity,
       dimensions=_string_list_pairs_from_dict(entity.dimensions),
       state=json.dumps(entity.state, sort_keys=True, separators=(',', ':')),
@@ skipping 161 matching lines @@
       kwargs['costs_usd'].append(entity.cost_usd)
     kwargs['properties_hash'] = None
     kwargs['tags'] = []
     kwargs['user'] = None
   else:
     assert entity.__class__ is task_result.TaskResultSummary, entity
     kwargs['properties_hash'] = (
         entity.properties_hash.encode('hex')
         if entity.properties_hash else None)
   return _ndb_to_rpc(swarming_rpcs.TaskResult, entity, **kwargs)