Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2661153005: Fix some problems with lexical error recovery. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some problems with lexical error recovery. * current.next was sometimes null. * recoverUnmatched would create a cycle. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/92cfd09e42dff62f5946cb1db2815af1729ac590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -18 lines) Patch
M pkg/front_end/lib/src/fasta/scanner/recover.dart View 4 chunks +14 lines, -7 lines 0 comments Download
M pkg/front_end/test/fasta/parser/parser.status View 7 chunks +21 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 10 months ago (2017-02-01 15:02:07 UTC) #2
karlklose
LGTM
3 years, 10 months ago (2017-02-01 15:06:19 UTC) #3
ahe
3 years, 10 months ago (2017-02-01 15:24:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
92cfd09e42dff62f5946cb1db2815af1729ac590 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698