Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: remoting/base/logging.h

Issue 2661153003: Moving oauth code from host to base to allow code sharing between host and client. (Closed)
Patch Set: Correcting minor mistakes found in CL. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/base/gaia_oauth_client.cc ('k') | remoting/base/mock_oauth_client.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_BASE_LOGGING_H_ 5 #ifndef REMOTING_BASE_LOGGING_H_
6 #define REMOTING_BASE_LOGGING_H_ 6 #define REMOTING_BASE_LOGGING_H_
7 7
8 #include "base/logging.h" 8 #include "base/logging.h"
9 9
10 namespace remoting { 10 namespace remoting {
11 11
12 // Chromoting host code should use HOST_LOG instead of LOG(INFO) to bypass 12 // Chromoting host code should use CRD_LOG or HOST_LOG instead of LOG(INFO) to
13 // the CheckSpamLogging presubmit check. This won't spam chrome output because 13 // bypass the CheckSpamLogging presubmit check. This won't spam chrome output
14 // it runs in the chromoting host processes. 14 // because it runs in the chromoting host processes.
15 // In the future we may also consider writing to a log file instead of the 15 // In the future we may also consider writing to a log file instead of the
16 // console. 16 // console.
17 #define CRD_LOG LOG(INFO)
Sergey Ulanov 2017/02/02 01:55:30 HOST_LOG has clear purpose (messages that are logg
17 #define HOST_LOG LOG(INFO) 18 #define HOST_LOG LOG(INFO)
18 #define HOST_DLOG DLOG(INFO) 19 #define HOST_DLOG DLOG(INFO)
19 20
20 } // namespace remoting 21 } // namespace remoting
21 22
22 #endif // REMOTING_BASE_LOGGING_H_ 23 #endif // REMOTING_BASE_LOGGING_H_
OLDNEW
« no previous file with comments | « remoting/base/gaia_oauth_client.cc ('k') | remoting/base/mock_oauth_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698