Issue 2661123002: Don't resynthesize field types during class members resynthesis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2661123002: Don't resynthesize field types during class members resynthesis. (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't resynthesize field types during class members resynthesis. Invalid code might cause recursion and stack overflow. And actually we might not need this type at all. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2a10f4bbb76996461c738ac0088a8def61474ef0

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -13 lines)			Patch
M	pkg/analyzer/lib/src/dart/element/element.dart	View	4 chunks	+18 lines, -11 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_ast.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_common.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/summary_common.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 10 months ago (2017-01-31 16:28:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2a10f4bbb76996461c738ac0088a8def61474ef0 (presubmit successful).