Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 266103002: components: Eliminate ios checks from individual gyp include files. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
blundell
CC:
chromium-reviews
Visibility:
Public.

Description

components: Eliminate ios checks from individual gyp include files. We don't need to wrap the targets of these files inside ios condition because we already do this in components.gyp. BUG=325241 TEST=gyp + build + green trybots R=blundell@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -93 lines) Patch
M components/navigation_interception.gypi View 1 chunk +56 lines, -60 lines 0 comments Download
M components/plugins.gypi View 1 chunk +28 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
6 years, 7 months ago (2014-05-03 23:32:20 UTC) #1
blundell
LGTM - thanks!
6 years, 7 months ago (2014-05-05 08:59:54 UTC) #2
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 7 months ago (2014-05-05 15:40:54 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-05 15:40:54 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-05 15:40:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/266103002/1
6 years, 7 months ago (2014-05-05 15:41:31 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 15:42:36 UTC) #7
Message was sent while issue was closed.
Change committed as 268188

Powered by Google App Engine
This is Rietveld 408576698